Re: PATCH: ppc fix 2

[Marcus Meissner]

On Wed, Oct 30, 2002 at 07:56:10AM -0600, Greg Turner wrote:
> On Wednesday 30 October 2002 07:22 am, Marcus Meissner wrote:
> > Hi,
> >
> > Just a bad macro.
> >
> > ciao, marcus
> >
> > Changelog:
> >    Fixed LITTLE_ENDIAN_32_READ macro to at least compile.
> > Index: ndr_marshall.c
> >
> > RCS file: /home/wine/wine/dlls/rpcrt4/ndr_marshall.c,v
> > retrieving revision 1.9
> > diff -u -r1.9 ndr_marshall.c
> > --- ndr_marshall.c	29 Oct 2002 23:07:33 -0000	1.9
> > +++ ndr_marshall.c	30 Oct 2002 13:21:15 -0000
> > @@ -59,8 +59,8 @@
> >
> > #define LITTLE_ENDIAN_32_READ(pchar) \
> >      (MAKELONG( \
> > -
> >  MAKEWORD(*(pchar), *((pchar)+1)) \
> > -
> >  MAKEWORD(*((pchar)+2), *((pchar)+3)))
> > -
> >  MAKEWORD(*(pchar), *((pchar)+1)), \
> > -
> >  MAKEWORD(*((pchar)+2), *((pchar)+3))))
> >
> > #endif
> >
> > /*
>
> oops!  thanks!  strange that this compiles for i386 at all.  maybe gcc 
> is automagically fixing the macro for some of us?

No, if you look at the define, it is not processed on i386 (protected
by ifdef).

Ciao, Marcus