The IsBad{Read,Write}Ptr implementation looked too complex to copy it around everywhere. And idk how to debug a crash that I've only seen in a .NET backtrace once.
Feel free to change the patches to how you would do it. I have attached the crash message from osu!.
On Tue, 19 Oct 2021 at 19:42, Alexandre Julliard julliard@winehq.org wrote:
Torge Matthies openglfreak@googlemail.com writes:
A crash in osu! was reported on Discord that segfaulted in this function. I don't know if there is any underlying bug and if adding these patches just hides a bug, but the current behavior of select() of just crashing is definitely wrong.
Maybe, but we don't want to add such pointer checks all over the place. If there's an actual app that requires this, it should be done with an exception handler. But first it should be confirmed that it's not a Wine bug that's causing the invalid pointer.
-- Alexandre Julliard julliard@winehq.org