Dmitry Timoshkov dmitry@baikal.ru writes:
I hoped that this is some kind of a joke or a test, and I simply didn't get it, but looks like my hope was futile. It appears that just moving existing structure definition (yes, they all exist in current code) to the beginning of the file (so that it could be used in more places) is forbidden without any real explanation. That's too much even for a person like me with 14 years history of working on Wine, I can imaging what new-comer feels about such a reject, and there should be not wonders why he/she would go away.
The structs were not used at all previously, only the variables. Now that they are used as structs they should have decent names.
Alexandre, if you would silently remove those underscores if you really don't like to see them I'd just probably decided not bother to comment once I saw it in the commit, but plain rejection of the patch just because of that looks at least strange and unexplainable.
You also received comments from Vincent that you need to address.
I should add that this kind of a not justified rejection easily kills any motivation to send patches at all.
This goes both ways: every time someone comments on a patch of yours, you reply defensively and state that you refuse to make the requested changes. That doesn't exactly encourage giving you good feedback.