Re: [4/9] wined3d: replace vendor specific callbacks with generic code that uses vendor specific renderer string tables

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-07-04 00:40, schrieb Andrei Slăvoiu:
> +/* See http://developer.amd.com/drivers/pc_vendor_id/Pages/default.aspx
> -
> -
> -
> - Beware: renderer string do not match exact card model,
> -
> - eg HD 4800 is returned for multiple cards, even for RV790 based ones. */

This link is dead. I recommend to remove it.
> static const struct gl_vendor_selection
>  {
>      enum wined3d_gl_vendor gl_vendor;
>      const char *description;        /* Description of the card selector i.e. Apple OS/X Intel */
> - enum wined3d_pci_device (*select_card)(const char *gl_renderer);
> - const struct
> - {
> -
>    const char *renderer;
> -
>    enum wined3d_pci_device id;
> - } *cards;                       /* To be used as cards[], pointer to the first member in an array */
> - size_t nr_cards;                /* Number of entries in the array above */

I think it would be nicer to give the structure a name instead of declaring it twice.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTt8jBAAoJEN0/YqbEcdMwhskQAIV3GnqWmcBsxdq8rIGHUw/r
lIP7nIxp65wxXSykylXJsPZDgyDGkQzb62u8StS1TBm+yjNy0sLR/A4vqHiZyUeN
Kv6AAp/3xtSfykYLNw7dJKmSjhaMdXDo6tx8pB3r1KT1bygNu3tGEMmSjAnRDk94
wJPCsl1Gkl1VIPo6aNnEfaKSVAbLxCtGK1SxCZc9SznGSJLNDhNdPiqC2+s/8JUZ
2/+uSPpilHEQVyBf+pi1fnq+RXwZ23S2+Qc7IkYPegX4z75M/BP0IKo+8eXYmOP5
KLL0C6TyVOp06Q6cNUCqOVpoSu+7Mnm4aS423QUb5hlfcDTV67mgyrVYkQTwkn9h
L9lxMldW/DzGMsY3GceVOZ7tm3VgTziT06FQjKcXuMknfhgPiXab2iHZYHgz7YJF
hCbGA9WSeYd9UuNKu8AmeGGFuAg+IuFLfnbVSG1idF1yFT/wlaiyLnA8Vc7//cI/
PRrn8UuiUS94cNLp5lSyl8cS8kzk3hW3Nf5mkRCqSJQXvJb2mLq38Hr9VR98rCQr
9L3aIOG5HIn1Uzwng4KywtGvyNbySsgiUPJgQqQMwS3HgwAGprPt7lF0b6fTMQym
v7l9/gx73pQQEpBAjBpIJPt9CAaUrhziPdciMojT/cBRhmBBDoDZJTtxe0LZorNL
Yz7Iw8f+i5Pag4QlZrxF
=Xnv/
-----END PGP SIGNATURE-----