Re: [PATCH 3/4] vbscript: Implemented Abs(try 7)

[Piotr Caban]

Hi,

On 07/11/14 05:49, Shuai Meng wrote:
> static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res)
>   {
> - FIXME("\n");
> - return E_NOTIMPL;
> - TRACE("(%s)\n", debugstr_variant(arg));
> -
> - assert(args_cnt == 1);
> -
> - if(!res)
> -
>    return S_OK;
> -
> - return VarAbs(arg,res);
> }

You're not handling res==NULL case correctly. E.g. Call Abs("string") 
should fail.

Thanks,
Piotr