Hi,
thanks for the additional information. ... I get that, I totally do. But I'm not fully sure if I can comply in all the detail.
Let's try it like this -- will this already suffice?
Thanks,
Gero
------------>8 snip
$ git diff diff --git a/dlls/winemac.drv/keyboard.c b/dlls/winemac.drv/keyboard.c index 3e0ebbf6ec..b0e2d8ea85 100644 --- a/dlls/winemac.drv/keyboard.c +++ b/dlls/winemac.drv/keyboard.c @@ -159,6 +159,7 @@ enum { kVK_F16 = 0x6A, kVK_F14 = 0x6B, kVK_F10 = 0x6D, + kVK_APPS = 0x6E, kVK_F12 = 0x6F, kVK_F15 = 0x71, kVK_Help = 0x72, @@ -294,7 +295,7 @@ static const struct { { VK_F14, 0x65, TRUE }, /* kVK_F14 */ { 0, 0, FALSE }, /* 0x6C unused */ { VK_F10, 0x44, TRUE }, /* kVK_F10 */ - { 0, 0, FALSE }, /* 0x6E unused */ + { VK_APPS, 0x6E, TRUE }, /* kVK_APPS */ { VK_F12, 0x58, TRUE }, /* kVK_F12 */ { 0, 0, FALSE }, /* 0x70 unused */ { VK_F15, 0x66, TRUE }, /* kVK_F15 */ @@ -393,6 +394,7 @@ static const struct { { VK_VOLUME_DOWN | 0x100, "Volume Down" }, { VK_VOLUME_MUTE | 0x100, "Mute" }, { VK_VOLUME_UP | 0x100, "Volume Up" }, + { VK_APPS, "Apps" }, };
HKL CDECL macdrv_GetKeyboardLayout(DWORD); $
Am 26.03.18 um 13:18 schrieb Aaryaman Vasishta:
Hi,
Thanks for the patch!
You might want to submit it as per the guidelines mentioned here https://wiki.winehq.org/Submitting_Patches.
Cheers, Aaryaman
On Mon, Mar 26, 2018 at 8:07 PM, Gero Zahn <geroz@gmx.de mailto:geroz@gmx.de> wrote:
Hi, I submitted a pull-request over at https://github.com/wine-mirror/wine/pull/9 <https://github.com/wine-mirror/wine/pull/9> and @AndreRH was so kind as to inform me that it wouldn't be picked up over there. ;-) So, here goes: I'm using wine on macOS with a regular PC keyboard. When using Windows applications, I miss support for the right popup menu key -- that's not the right Windows / Command key, but actually VK_APPS. I've been patching winemac.drv.so <http://winemac.drv.so> via hex editor manually for quite a while to enable support for this key. Now I thought that I might contribute this otherwise harmless improvement back to the source code. ... I have to admit that I didn't compile the patch myself. :-( But I am convinced that my modification to the source should result in the desired functionality. Here's the (minuscule) patch to keyboard.c -- if the format shouldn't suffice, you can find everything else in above mentioned wine-mirror link at https://github.com/wine-mirror/wine/pull/9/files <https://github.com/wine-mirror/wine/pull/9/files> ---------->8 snip $ diff keyboard_orig.c keyboard_patched.c 161a162 > kVK_APPS = 0x6E, 297c298 < { 0, 0, FALSE }, /* 0x6E unused */ --- > { VK_APPS, 0x6E, TRUE }, /* kVK_APPS */ 395a397 > { VK_APPS, "Apps" }, $