On Mon, Apr 25, 2016 at 10:49:07PM -0600, Alex Henrie wrote:
2016-04-25 22:17 GMT-06:00 Nikolay Sivov bunglehead@gmail.com:
On 26.04.2016 6:09, Alex Henrie wrote:
Cc: Andrew Eikum aeikum@codeweavers.com
Signed-off-by: Alex Henrie alexhenrie24@gmail.com
dlls/qedit/Makefile.in | 3 +- dlls/qedit/qedit_private.h | 2 + dlls/qedit/tests/timeline.c | 3 - dlls/qedit/timeline.c | 10 +- dlls/qedit/timelineobj.c | 470 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 482 insertions(+), 6 deletions(-) create mode 100644 dlls/qedit/timelineobj.c
I think it's better to add this to timeline.c.
I'm not sure it's a good idea to shove everything into one file. Andrew, what do you think?
I agree with Nikolay, we generally prefer fewer source files. The timeline and timeline objects are all related, so let's keep them in the same file.
Nothing, but I'll add a test for this and resubmit. I will also make the rest of the changes to this patch that you suggested.
Like Nikolay said, since there's no API to create instances as aggregate objects, there's no need for the separate IUnknown implementation.
Personally, I like leaving the ZeroMemory in since this isn't performance-critical code and it future-proofs against forgetting to initialize newly added fields. But I wouldn't reject a patch either way.
Andrew