On Monday, September 28, 2015, Andrew Eikum aeikum@codeweavers.com wrote:
On Sun, Sep 27, 2015 at 12:42:42AM +0800, Bruno Jesus wrote:
Signed-off-by: Bruno Jesus <00cpxxx@gmail.com javascript:;>
Tomb Raider 3 uses a single archive with all wav files inside, when playing some specific sounds it passes incorrect lengths of data that reach the next wav file header. This causes an assert in the code that is now gracefully handled.
...
Looks reasonable, thanks. I think you should change that message to a WARN. Audio methods are often called thousands of times per second, so spamming an ERR can be very obnoxious.
Will do, thanks for the review. Does this mean I should add a Signed-off-by with your name too? Or that is not related to patch reviewing.