Re: [PATCH vkd3d 6/8] vkd3d-shader/hlsl: Use a more sensible source location in add_constructor().

[Giovanni Mascellani]

Hi,

Il 28/04/22 20:21, Zebediah Figura ha scritto:
> Note that this makes the "loc" parameter to initialize_var_components() 
> redundant.

Right. If that's ok for you, I'd fix it in a follow up.
> I think this patch makes sense, although do you happen to have an 
> example of an error message that's improved this way?

No, not really. Ideally initialize_var_components() should never fail, 
except for memory allocation, for which loc doesn't make much sense any 
way. My idea is to keep the code "sensible" even when that isn't 
expected to be apparent to the user.

No big deal if the patch is dropped.

Giovanni.