On Sat, Dec 26, 2009 at 11:06 AM, Jacek Caban jacek@codeweavers.com wrote:
I've been following cmd.exe topic and I was concerned about the fact, that these tests are out of Wine tree, so I wanted to help and implemented a simple framework. I almost didn't test it so I didn't send it before. It caused a code duplication, I'm sorry about that. I'm attaching the patch (it requires running tools/make_makefiles) and I will leave it for others.
Thanks! I'll smash them together when I get to a linux system.
Also, your tests are very risky in terms of non-English locales. I think we shouldn't test error messages strings.
Can we force the locale to a particular value for the tests with a registry key or something? It'd be pretty hard to write tests without checking *any* error messages.
A problem with directory in prompt may be fixed by special escape in expected result file that would be replaced by the right directory in runtime.
Sure, but using the prompt command works around it more easily; see my test scripts. - Dan