Re: advpack.c must be compiled with optimization?

[Michael Karcher]

Am Montag, den 26.05.2008, 22:16 -0700 schrieb Dan Kegel:
> Oddly, if I compile the wine tree without -O2, the following
> test fails:
>
> ../../../wine advpack_test.exe.so advpack.c
> advpack.c:441: Test failed: Expected C:\Program Files, got C:\
> advpack.c:443: Test failed: Expected size 17, got 4
> make: *** [advpack.ok] Error 2
>
> Compiling advpack/advpack.c with at least -O makes
> the problem go away.

Evil bug of using uninitialized stack space caused by not checking
return values. It usually slips through, as the local variable was
"initialized" in a previous run of get_dest_dir. Working patches are
available and will be submitted in the next hour.

Regards,
  Michael Karcher