On Thu, Jul 12, 2018 at 3:16 PM Nikolay Sivov nsivov@codeweavers.com wrote:
On 07/12/2018 03:30 PM, Alex Henrie wrote:
This resolves several warnings when compiling with GCC 8.1.
Unfortunately it's not about gcc, it's a libxml2 change [1], looks like first affected version is 2.9.8. This commit is good in a sense that it removes pointer casts, and uses correct prototypes everywhere. Why did they have to change public prototype signature, for argument that wasn't used in a first place, that I don't understand. I wonder if Daniel would be open to revert this back to what it was, otherwise we'll need a version check around those helpers to suppress the warning.
[1] https://gitlab.gnome.org/GNOME/libxml2/commit/e03f0a199a67017b2f8052354cf732...
Thanks for the explanation. At least the change didn't break binary compatibility. I wonder if the parameter was meant to be const all along and omitting the keyword was a mistake that libxml2 is now trying to fix?
-Alex