Hi,
Il 27/08/21 11:52, Matteo Bruni ha scritto:
You don't want to introduce dead code though, so making that kind of split at this point is a bit awkward.
My suggestion would not introduce dead code (i.e., code that never gets executed). You move some code to another function, but still call it.
Personally I'm generally for introducing shared helpers as they become necessary rather than upfront. For example, if at the time of implementing conditional or loop instructions, as it's likely, some existing code parts can be nicely reused, a new helper can be created by factoring out the relevant code. An upside of waiting for a second user is that you're sure to make the helper(s) you know you need rather than what you now think you'll need at some point in the future.
Well, in a sense I am already that second user: I have patches for ifs and loops, including a patch that introduces the write_sm4_block helper I suggested (with precisely that signature).
That said, no problem going through another patch.
Thanks, Giovanni.