On Wed, Jun 3, 2020 at 6:18 PM Zebediah Figura zfigura@codeweavers.com wrote:
On 6/3/20 11:04 AM, Matteo Bruni wrote:
On Tue, Jun 2, 2020 at 12:59 AM Zebediah Figura z.figura12@gmail.com wrote:
In particular so that we can remove the need for creating a load instruction, which besides being unnecessary was also never added to any instruction lists.
Well reviewed :/
I guess part of the issue is that some of the new_*() helpers add the instruction to the list and some don't. I'd say let's pick one and follow it through consistently (possibly by renaming the functions that do the opposite thing to not have the form "new_*").
Yeah, I noticed that too. I think renaming functions is a good way around this. Possibly "new_*" for functions that just allocate, and "add_*" for functions that add it to the list.
Sounds good to me.