Re: [PATCH] wmvcore: Add WMReader stubs.

[Alistair Leslie-Hughes]

Hi Jefferson,

On 30/03/17 10:18, Jefferson Carpenter wrote:
> I have not written unit tests for this code.  I would like to add some
> wmvcore tests, but am not very familiar with Wine's build system
> autotools, and have not been able to get tests to compile and run.

I have a basic patch for adding tests in the works, but I was waiting
for my IDL changes to be accepted first.

So, If someone wants to review the IDL changes, Since Sebastian has been
busy with other stuff.

https://source.winehq.org/patches/data/131403
> Signed-off-by: Jefferson Carpenter
>
> dlls/wmvcore/wmvcore_main.c | 1234 +++++++++++++++++++++++++++++++++++++++++++
> +static HRESULT WINAPI WMHeaderInfo_GetScriptCount(IWMHeaderInfo3 *iface, WORD *pcScripts)
> +{
> - WMReader *This = impl_from_IWMHeaderInfo3(iface);
> - FIXME("(%p)->(WMHeaderInfo_GetScriptCount)\n", This);

This is incorrect. The FIXME will insert the function name into the
logs.  You need to specify each parameter in the FIXME, there are plenty
of examples of how to do this.

Best Regards
 Alistair Leslie-Hughes