Paul Vriens wrote:
Hi,
to ease Alexandre's work I re-diffed the patch. The consensus on wine-devel was that this patch is fine.
This patch makes the crosstest compile work again for shell32. Result tested on win98/winxp/Wine/W2KProf.
Changelog: Use aliases for calls to ordinals.
I don't think that's what the consensus says, if a consensus there is in the first place.
If I understand Filip Navara's patch correctly, it shows that the fix belongs in MinGW's shell32.def file. And if that's the case then I'm arguing this test should remain as is.
As I understand it, once MinGW's file is fixed, the compiler sees that there is an ordinal associated to SHSimpleIDListFromPath and then generates an executable which imports SHSimpleIDListFromPath by ordinal. This seems to be exactly what Visual C++ does on Windows.
It's perfectly acceptable to import SHSimpleIDListFromPath by name in programs compiled using Visual C++, and the resulting executable works even if shell32.dll exports this API by ordinal only. Our conformance tests should reflect that. That's because they are meant to reflect the Windows behavior (not the MinGW one), including where compilation and linking are concerned.