On 7/12/21 6:43 AM, Henri Verbeet wrote:
On Sat, 10 Jul 2021 at 23:02, Zebediah Figura (she/her) zfigura@codeweavers.com wrote:
On 9/14/20 10:47 AM, Henri Verbeet wrote:
On Sat, 12 Sep 2020 at 21:26, Zebediah Figura zfigura@codeweavers.com wrote:
We tag far fewer symbols this way.
Using -fvisibility=hidden seems fine, but I'm not sure that's a compelling reason to switch. It's been a while, but IIRC we chose the current scheme to be consistent with Wine, and wined3d in particular.
At the time I was willing to leave this alone, but every time since that I try to shuffle functions around or add internal helpers, I find myself missing this patch, and I'd like to argue for it a second time.
Personally, adding DECLSPEC_HIDDEN has never particularly bothered me, but in this particular case, if it bothers you that's probably sufficient reason. I would be curious about opinions from Matteo and Conor in particular as well though.
To be fair it's not a huge annoyance, certainly not enough to justify several paragraphs....