Re: comctl32: Remove unused last parameter from TOOLTIPS_EnumToolsT.

[Nikolay Sivov]

On 8/23/2010 00:51, Gerald Pfeifer wrote:
> dlls/comctl32/tooltips.c |    6 ++----
>   1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c
> index 688d3b5..d17f067 100644
> --- a/dlls/comctl32/tooltips.c
> +++ b/dlls/comctl32/tooltips.c
> @@ -1177,8 +1177,7 @@ TOOLTIPS_DelToolT (TOOLTIPS_INFO *infoPtr, const TTTOOLINFOW *ti, BOOL isW)
>   }
>
> static LRESULT
> -TOOLTIPS_EnumToolsT (const TOOLTIPS_INFO *infoPtr, UINT uIndex, TTTOOLINFOW *ti,
> -
>                 BOOL isW)
>
> +TOOLTIPS_EnumToolsT (const TOOLTIPS_INFO *infoPtr, UINT uIndex, TTTOOLINFOW *ti)
>   {
>       TTTOOL_INFO *toolPtr;
>
> @@ -2176,8 +2175,7 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
>                                         uMsg == TTM_DELTOOLW);
>    case TTM_ENUMTOOLSA:
>    case TTM_ENUMTOOLSW:
> -
>    return TOOLTIPS_EnumToolsT (infoPtr, (UINT)wParam, (LPTTTOOLINFOW)lParam,
> -
>                                    uMsg == TTM_ENUMTOOLSW);
> -
>    return TOOLTIPS_EnumToolsT (infoPtr, (UINT)wParam, (LPTTTOOLINFOW)lParam);
> case TTM_GETBUBBLESIZE:
>      return TOOLTIPS_GetBubbleSize (infoPtr, (LPTTTOOLINFOW)lParam);

This needs to be implemented properly instead of being removed. 
Significant part is here:

---
/*    ti->lpszText = toolPtr->lpszText; */
     ti->lpszText = NULL;  /* FIXME */
---

which needs some tests. It's really doubtful that text is not returned 
when A/W messages exist.