Francois Gouget fgouget@codeweavers.com writes:
This also causes the ShellExecute() and association descriptions to be printed with each failing test. This makes the messages more readable in TestBot's abbreviated logs, at the cost of a lot more redundancy.
Signed-off-by: Francois Gouget fgouget@codeweavers.com
Honestly, this thing is getting out of hand. Not only is this adding a lot of complexity for a trivial difference in output, but it has actually made the traces less readable IMO. Can we please get rid of the fancy macros and go back to printing the relevant information in the ok() calls, like all other tests do? Pretty please?
Would the following approach be ok? Because going back to starting every ok() call with "%s ...", shell_call, ... is really ugly. With this approach the ShellExecute() and association description is shown on all messages which I presume fixes the readability issue you had with the previous approach.
Yes, that would be fine, thanks.