Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.

[Andrew Eikum]

On Thu, Mar 29, 2012 at 04:18:20PM +0200, Christian Costa wrote:
> It's the original code. I decided to keep it in this patch and add error
> checking in the patch that comes just after.
> I can merge them but I prefer to do things incrementally as much as
> possible.

Ah, sure enough. I missed that patch. Though in [3/5], you're missing
assigning hr for _GetPortCaps(). I also think it would be nice to WARN
with the result code in the failure case (or TRACE if a failure is
expected in some cases). You know, the usual
"if(FAILED(hr)){WARN(..., hr); return hr;}" error checking thing.