Alex Villacís Lasso wrote:
Andrew Talbot escribió:
How should one report minor code errors that don't necessarily produce known bad behaviour? To give a concrete example, in msacm32:driver.c acmDriverPriority(), formal parameter dwPriority is of type DWORD, which is unsigned, but it contains a line that reads:
if (dwPriority < 0) dwPriority = -1;... which can never happen.
So -1 is actually a documented value for dwPriority. However, you are right in that a DWORD (a typedef for an unsigned long) won't ever return true for a comparison such as dwPriority < 0.
Yes, I didn't highlight where the problem really lay, there.
I will prepare a patch shortly. The wine-devel list might be actually a good place to post code anomalies, as illustrated by the fact that it caught my attention (because I put that code in the first place :-) ).
Alex Villacís Lasso
Thank you for your kind and quick response, Alex.
-- Andy.