Re: WineD3D: let flush_to_framebuffer_drawpixels use a valid rect

[Stefan Dösinger]

Am Dienstag, 19. Februar 2008 21:26:24 schrieben Sie:
> Hi,
>
> Originally flush_to_framebuffer_drawpixels was called from UnlockRect, so
> in that case LockedRect was always set. These days it can also be called
> (through LoadLocation) from other places. This patch makes it use the
> LockedRect when the surface is locked else the whole surface is uploaded.
> This fixes rendering issues in Red Alert and other apps.

Wouldn't it be better to make sure that the caller passes the correct 
rectangle to flush_to_framebuffer_* ?
> -
>        if(dxVersion >= 8) {
> -
>        if(0 && dxVersion >= 8) {

Is this intentional?