Le 19/02/2022 à 20:38, Roman Pišl a écrit :
Hi Eric,
Dne 19. 02. 22 v 19:49 Eric Pouech napsal(a):
struct message {
@@ -2819,6 +2820,10 @@ static void ok_sequence_(const struct message *expected_list, const char *contex context, count, expected->message); if ((expected->flags & kbd_hook) != (actual->flags & kbd_hook)) dump++; + todo_wine_if(expected->flags & has_update) + ok_( file, line) (!(expected->flags & has_update) || (actual->flags & has_update), + "%s: %u: the msg 0x%04x should have update region\n", context, count, expected->message );
expected++; actual++; }
Hi Roman
please, don't outdent the todo_wine*
that generates warnings with mingw gcc 11.x
thanks
unfortunately this code mixes tabs and spaces in a very ugly way - it indents by 4 but tab size is expected to be 8. I'll fix it in the next version after review..
Or would a patch that removes completely all tabs from the file be acceptable?
no. gratuitous space/tab changes are not accepted.
generally, for space/tab choice, the rule is to keep the options taken for the file to edit...
hard to tell on this file what's the choice made <g>
in this case, I'd say go for spaces only.
A+