Re: [PATCH 1/3] msxml3: Update orphant list in put_documentElement.

[Michael Karcher]

Am Donnerstag, den 16.10.2008, 15:42 -0500 schrieb Jacek Caban:
> > So, I doubt this patch is correct.
>
> This patch fixes regression in Photoshop CS4 installer caused by your 
> patch. The double free is exactly what happened with your patch and my 
> patch fixes it. The new root has to be removed from orphan list because 
> it is added to DOM tree. Otherwise we'd free it two times. Also oldRoot 
> is no longer in DOM tree, so it should be added to orphan list to be 
> freed later.

Sorry, I was confused. Your patch is completely correct. I mixed up the
root element and the document element.

Regards,
  Michael Karcher