Hello,
On Thu, Nov 8, 2012 at 3:25 AM, Alexandre Julliard julliard@winehq.org wrote:
It's here to support Unicode data in wine.inf, as you noted. However, I don't think it makes sense to add the BOM unless we actually have Unicode keys in there.
Thanks for explain!
Let me make a summary of Bug 32136:
Since Wine1.4 we added the 'font replacement' feature to Wine, and leave the 'font replacement' setting to distribution folks, for example, Ubuntu's Wine packager has a patch like 0001-tools-wine.inf.in-Added-font-name-replacement.txt
To solve Bug 32136, we need not only English font name replacement for CJK fonts, but also localized font name replacement for CJK fonts, so Ubuntu need to update their patch like 0001-tools-wine.inf.in-Added-localized-font-name-replacemen.txt.
The second patch is a bit strange and ugly, because it change the encoding of a upstream file, that will make people confused. What's worse, once Wine update the encoding of wine.inf.in from ANSI to UTF8_with_bom in the future, the second patch will confilict to the new wine.inf.in.
My idea is split the second patch into two parts, the first part is 0001-tools-wine.inf.in-Added-UTF8-bom-header.txt, the second part is adding english and localized font name replacement settings without changing the encoding of wine.inf.in.
Did I explain clearly enough? Does that make sense?
Thank you!
-- Regards, Qian Hong
- Sent from Ubuntu http://www.ubuntu.com/