Re: [PATCH v4 15/17] x86/traps: Fixup general protection faults caused by UMIP

[Peter Zijlstra]

On Wed, Feb 22, 2017 at 10:37:04PM -0800, Ricardo Neri wrote:
> @@ -492,6 +493,9 @@ do_general_protection(struct pt_regs *regs, long error_code)
>    RCU_LOCKDEP_WARN(!rcu_is_watching(), "entry code didn't wake RCU");
>    cond_local_irq_enable(regs);
> - if (user_mode(regs) && (fixup_umip_exception(regs) == true))
> -
> return;

I'm thinking

if (user_mode(regs) && fixup_umip_exception(regs))
    	return;

is actually easier to read.