Dan Kegel wrote:
Chris Ahrendt wrote:
Again on the goto's I was following what the site suggested was a good task to start with
Where does it say that? I looked, but I couldn't find it. Please let me know so I can go make sure it's accurate.
Wine code is a bit like kernel code, it has slightly different conventions than most people are used to.
Chris, you should focus on one thing at a time, and code cleanup probably shouldn't be something you focus on until you are more in tune with Wine.
- Dan
p.s. Also, everybody, please trim your quotes...
Thanks for the pointer Dan...
here is the section I am talking about:
Perform a focused code review
Here are a few starting points:
* Arrays of fixed sized like 'foo[100]'. 100, where does that come from? * Arrays of size 255, 256, 512, 1024. These are most likely variables destined to contain a path. But then they should be using one of the standard macros like MAX_PATH, MAX_PATHNAME_LEN or some such. Which one? * Calls to sprintf with an incorrect buffer size * Inefficient uses of strcat (not really a bug and not really vital)
Required skills:
* C programming
A Typical code review I do when I go to clients includes the above but also includes such things as goto's and incorrect variable declarations.. Uninitialized variables... use of NULL instead of memset to set variables, etc... If there is a specific code convention that wine uses you might want to document or put a link here so there is no confusion. Only reason I started there was due to the simplicity implied =)
chris