2015-12-15 11:10 GMT+01:00 Henri Verbeet hverbeet@gmail.com:
On 14 December 2015 at 23:37, Matteo Bruni mbruni@codeweavers.com wrote:
@@ -4426,7 +4428,7 @@ HRESULT CDECL wined3d_check_device_multisample_type(const struct wined3d *wined3 if (quality_levels) { if (multisample_type == WINED3D_MULTISAMPLE_NON_MASKABLE)
*quality_levels = gl_info->limits.samples;
*quality_levels = wined3d_log2i(gl_info->limits.samples); else *quality_levels = 1;I'm not sure this really makes sense. It may make sense to limit the number of non-maskable quality levels to 8, similar to how we limit e.g. shader constants and render targets for d3d9, although that would need a test and a comment. I don't see how you can justify the wined3d_log2i().
It seems to roughly match native, where higher quality levels for WINED3D_MULTISAMPLE_NON_MASKABLE generally mean an increased number of samples per pixel (at least going by the output of DX9FSAAViewer, from bug 12652) and sample counts often go up by powers-of-two. That's not always the case of course but it seems like we can use the idea as a possible valid implementation of WINED3D_MULTISAMPLE_NON_MASKABLE.
Anyway I just realized this patch is missing the related changes to surface_prepare_rb(), as-is the patch doesn't make sense... Something like the attached patch is what I intended.
Actually there is also another option. Hardcoding the quality levels count to 1 might be acceptable? We might then just always pick MAX_SAMPLES (or maybe 2) as the samples count for WINED3D_MULTISAMPLE_NON_MASKABLE renderbuffers.