Re: [PATCH 4/4] wineoss: Move MIDM_STOP to the unixlib.

[Andrew Eikum]

Signed-off-by: Andrew Eikum

On Wed, Apr 27, 2022 at 08:03:20AM +0100, Huw Davies wrote:
> Signed-off-by: Huw Davies
>
> dlls/wineoss.drv/midi.c    | 16 ----------------
>  dlls/wineoss.drv/ossmidi.c | 17 +++++++++++++++++
>  2 files changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/dlls/wineoss.drv/midi.c b/dlls/wineoss.drv/midi.c
> index 9df97530865..fe73d97f5ab 100644
> --- a/dlls/wineoss.drv/midi.c
> +++ b/dlls/wineoss.drv/midi.c
> @@ -490,20 +490,6 @@ static DWORD midClose(WORD wDevID)
>      return ret;
>  }
>
> -/**************************************************************************
> -
> -
> 	midStop					[internal]
> - */
>
> -static DWORD midStop(WORD wDevID)
> -{
> - TRACE("(%04X);\n", wDevID);
> -
> - if (wDevID >= MIDM_NumDevs) return MMSYSERR_BADDEVICEID;
> - if (MidiInDev[wDevID].state == -1) return MIDIERR_NODEVICE;
> -
> - MidiInDev[wDevID].state = 0;
> - return MMSYSERR_NOERROR;
>
> -}
> -
>
> /*======================================================================*
> -
>              	    MIDI entry points 				*
>
> *======================================================================*/
> @@ -529,8 +515,6 @@ DWORD WINAPI OSS_midMessage(UINT wDevID, UINT wMsg, DWORD_PTR dwUser,
>    return midOpen(wDevID, (LPMIDIOPENDESC)dwParam1, dwParam2);
>      case MIDM_CLOSE:
>    return midClose(wDevID);
> -
>
> case MIDM_STOP:
> -
>
> return midStop(wDevID);
> }
>
> params.dev_id = wDevID;
>
> diff --git a/dlls/wineoss.drv/ossmidi.c b/dlls/wineoss.drv/ossmidi.c
> index 091eccd6d53..86d766eceaf 100644
> --- a/dlls/wineoss.drv/ossmidi.c
> +++ b/dlls/wineoss.drv/ossmidi.c
> @@ -1225,6 +1225,20 @@ static UINT midi_in_start(WORD dev_id)
>      return MMSYSERR_NOERROR;
>  }
>
> +static UINT midi_in_stop(WORD dev_id)
> +{
> - struct midi_src *src;
> -
> - TRACE("(%04X);\n", dev_id);
> -
> - if (dev_id >= num_srcs) return MMSYSERR_BADDEVICEID;
> - src = srcs + dev_id;
> - if (src->state == -1) return MIDIERR_NODEVICE;
> -
> - src->state = 0;
> - return MMSYSERR_NOERROR;
>
> +}
> -
>
> static UINT midi_in_reset(WORD dev_id, struct notify_context *notify)
>  {
>      UINT cur_time = NtGetTickCount();
> @@ -1340,6 +1354,9 @@ NTSTATUS midi_in_message(void *args)
>      case MIDM_START:
>          *params->err = midi_in_start(params->dev_id);
>          break;
> - case MIDM_STOP:
> -
>    *params->err = midi_in_stop(params->dev_id);
> -
>    break;
> case MIDM_RESET:
>        *params->err = midi_in_reset(params->dev_id, params->notify);
>        break;
>
> -- 
> 2.25.1