Re: [PATCH 3/3] msscript: Implement Timeout property

[Jacek Caban]

Hi Nikolay,

On 06/11/2016 12:02 PM, Nikolay Sivov wrote:
> static HRESULT WINAPI ScriptControl_put_Timeout(IScriptControl *iface, LONG milliseconds)
>  {
>      ScriptControl *This = impl_from_IScriptControl(iface);
> - FIXME("(%p)->(%d)\n", This, milliseconds);
> - return E_NOTIMPL;
> -
> - TRACE("(%p)->(%d)\n", This, milliseconds);
> -
> - if (milliseconds < -1)
> -
>    return CTL_E_INVALIDPROPERTYVALUE;
> -
> - This->timeout = milliseconds;
> - return S_OK;
>
> }

Getter/setter implementation seems fine, but it's not full
implementation and I'm pretty sure that at least first versions that
will be able to execute script code won't support that (builtin jscript
nor vbscript supports that, so there is very little point in
implementing it here), so FIXME or WARN here would be more appropriate here.

Thanks,
Jacek