Re: [PATCH 5/6] shlwapi/tests: Add missing return value checks to istream tests (Coverity)

[Nikolay Sivov]

On 01/08/2018 08:05 AM, Alex Henrie wrote:
> Signed-off-by: Alex Henrie
>
> dlls/shlwapi/tests/istream.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/shlwapi/tests/istream.c b/dlls/shlwapi/tests/istream.c
> index 54a73fcf5e..f49ddd1824 100644
> --- a/dlls/shlwapi/tests/istream.c
> +++ b/dlls/shlwapi/tests/istream.c
> @@ -663,8 +663,10 @@ static void test_SHCreateStreamOnFileEx_CopyTo(void)
>       static const WCHAR prefix[] = { 'T', 'S', 'T', 0 };
>   GetTempPathW(MAX_PATH, tmpPath);
> - GetTempFileNameW(tmpPath, prefix, 0, srcFileName);
> - GetTempFileNameW(tmpPath, prefix, 0, dstFileName);
> - ret = GetTempFileNameW(tmpPath, prefix, 0, srcFileName);
> - ok(SUCCEEDED(ret), "GetTempFileName failed, got error %d\n", GetLastError());
> - ret = GetTempFileNameW(tmpPath, prefix, 0, dstFileName);
> - ok(SUCCEEDED(ret), "GetTempFileName failed, got error %d\n", GetLastError());

Return value is not HRESULT code in this case.
>   ret = SHCreateStreamOnFileEx(srcFileName, STGM_CREATE | STGM_READWRITE | STGM_DELETEONRELEASE, FILE_ATTRIBUTE_TEMPORARY, FALSE, NULL, &src);
>   ok(SUCCEEDED(ret), "SHCreateStreamOnFileEx failed with ret=0x%08x\n", ret);