On 07/27/2018 04:38 PM, Roderick Colenbrander wrote:
Hi Jacek,
Why are you marking the ICD functions as private? This would break native vulkan-1 support, which requires these calls.
I'm adding a reason for winevulkan to be linked by winelib applications in patch 1/2. Such applications shouldn't be linking to any of ICD nor wine_* functions.
Note that -private means only that they will not be exposed by importlib. Those functions will still be exported by name by DLL and vulkan-1 may still forward to them. Do you expect that we will want to call them by name from C code outside winevulkan in the future? If yes, then we can drop this patch.
Thanks, Jacek