Hi Dan,
The last part of your patch, having to do with SysAllocStringByteLen(), seems correct to me, offhand. Maybe if you clean up the comment a bit more, sprinkle sugar on it, and resend, it'll make it in this time.
I'll polish it and fire in again next week, there doesn't seem much point in spamming the patch queue with changes that aren't obviously correct while the freeze is on (didn't stop me trying though!).
It's so gross, though, that it really should serve as a reminder to us to switch to IMalloc...
Yeah, its nasty, but it does make valgrind happy :-) I think reworking the memory allocation is going to be pretty far down the list for this dll though, there seem to be quite a few VB failures that should probably be tackled first...
I have to say I think getting the tests to pass valginding is a great way to fix bugs. I can't see any other way the variant leaks would have been found, for example. Cheers for a very readable wiki page, it was trivial to get it set up.
Cheers Jon