Re: [PATCH vkd3d 4/4] vkd3d-shader: Add support for retrieving the creator string from DXBC shaders.

[Zebediah Figura (she/her)]

On 1/6/22 04:15, Henri Verbeet wrote:
> On Tue, 28 Dec 2021 at 23:20, Zebediah Figura  wrote:
> > struct vkd3d_shader_parser_ops
> >   {
> >       void (*parser_reset)(struct vkd3d_shader_parser *parser);
> >       void (*parser_destroy)(struct vkd3d_shader_parser *parser);
> > - void (*parser_read_metadata)(struct vkd3d_shader_parser *parser);
> >  void (*parser_read_instruction)(struct vkd3d_shader_parser *parser, struct vkd3d_shader_instruction *instruction);
> >  bool (*parser_is_end)(struct vkd3d_shader_parser *parser);
> > };
>
> I don't feel strongly one way or another at this point, but should
> parser_read_metadata() perhaps just return the metadata to the caller,
> instead of storing it in the vkd3d_shader_parser structure?

I haven't written much more than these patches so far, but I think that 
makes sense.