Bump on the question of what happened to this patch.
On Mon, Oct 10, 2016 at 5:03 PM, Keno Fischer keno@juliacomputing.com wrote:
I had submitted v3 of this patch, but I don't see it on https://source.winehq.org/patches/ anymore. Was there some review comments I missed somewhere?
On Thu, Sep 8, 2016 at 10:44 PM, Keno Fischer keno@juliacomputing.com wrote:
Ok, that can probably be done with some linker script magic, since this is merely a warning in the assembler. I'll take a look at that.
On Thu, Sep 8, 2016 at 10:36 PM, Alexandre Julliard julliard@winehq.org wrote:
Keno Fischer keno@juliacomputing.com writes:
Whether .dynamic is writable depends on the architecture (I believe the only one on which it isn't is MIPS, but I could be wrong about that). Looks like binutils doesn't take that into account when issuing this diagnostic in the assembler and expects .dynamic to have SHF_ALLOC only. Probably something to complain about to them. I don't believe there's an actual problem though, just an incorrect diagnostic.
We don't want to introduce build warnings though, so even if this is a binutils bug it would have to be avoided somehow.
-- Alexandre Julliard julliard@winehq.org