Well, indeed, but is this really a good target to strive for and bring out as an example? The 4 patches add only a number of tests that verify difference between wine and windows UTF-7 encoding, missing stuff is marked as wine_todo, testbot has marked them as passing (meaning todo_wine marked tests are expected to fail on current wine and do so and same tests are supposed to pass on windows and do so), no actual implementation that would change the behavior of wine itself. So unless there is something wrong with the coding style (which hasn't been commented on after the last patches), shouldn't such patches (only tests, verified as valid by testbot) get included a lot faster than 10-30 days??
Regards, Indrek Altpere -----Original Message----- From: wine-devel [mailto:wine-devel-bounces@winehq.org] On Behalf Of Ruslan Kabatsayev Sent: Wednesday, October 29, 2014 9:48 AM To: Alex Henrie; Alex Henrie Cc: Alexandre Julliard; Wine Devel; Alexandre Julliard; Wine Devel Subject: Re: Need feedback on first four UTF-7 patches
Hi Alex,
If you look at http://source.winehq.org/patches/ , you'll see that there're some patches which are a month old, but still having "New" status. So please be patient, your ones are not that old yet :)
Regards, Ruslan
On Tue, Oct 28, 2014 at 11:13 PM, Alex Henrie alexhenrie24@gmail.com wrote:
Alexandre,
I submitted four UTF-7 patches on October 19 and am still waiting for feedback. I was hoping that these patches would not be controversial because they only add encoding tests. I have six additional patches waiting in https://github.com/alexhenrie/wine/commits/master - four patches for adding decoding tests and two patches to make all the tests pass - but I will not submit them until I get feedback about the first four that I have already submitted.
-Alex