Ah, I see. Yeah, that's weird. Have you tried asking Chip directly? I'm CC'ing him.
-Ken
On Apr 6, 2016, at 4:53 PM, Theodore Dubois tblodt@icloud.com wrote:
Yes, I did. The problem is that the code assumes that argv[0] - argv[1] (= offset) is a meaningful quantity, which it isn’t because each string in the argv array came from strdup.
~Theodore
On Apr 6, 2016, at 2:14 PM, Ken Thomases ken@codeweavers.com wrote:
Did you allocate one more entry in your argv than is needed for actual arguments and put a terminating NULL? You're supposed to.
-Ken
On Apr 6, 2016, at 3:41 PM, Theodore Dubois tblodt@icloud.com wrote:
This patch causes a segfault in the event that __wine_main_argv is not the argv that got passed to main. This happened in a program I wrote that acts as a custom wine loader. It creates an argv by using malloc, then passes that to wine_init.
Why wouldn’t setprogname(argv[1]) be adequate?
~Theodore
On Feb 19, 2016, at 2:33 PM, Charles Davis cdavis5x@gmail.com wrote:
Signed-off-by: Charles Davis cdavis5x@gmail.com