Re: [shell32 5/6] include: Add remotable stubs for non-default-marshallable shobjidl calls.

[Rob Shearman]

2009/1/1 Michael Karcher :
> diff --git a/include/shobjidl.idl b/include/shobjidl.idl
> index a647798..c36f4ce 100644
> --- a/include/shobjidl.idl
> +++ b/include/shobjidl.idl
> @@ -452,6 +452,9 @@ interface IShellView : IOleWindow
>          [in] LPFNSVADDPROPSHEETPAGE pfn,
>          [in] LPARAM lparam);
> - [call_as(AddPropertySheetPages)]
> - HRESULT RemoteAddPropertySheetPages();
> - HRESULT SaveViewState();
>    HRESULT SelectItem(
>        [in] LPCITEMIDLIST pidlItem,
>
> @@ -582,6 +585,9 @@ cpp_quote("#endif")
>          [in] LPARAM lParam,
>          [in] LRESULT *pret);
> - [call_as(SendControlMsg)]
> - HRESULT RemoteSendControlMsg();
> - HRESULT QueryActiveShellView( [out] IShellView **ppshv );
>    HRESULT OnViewWindowActive( [in] IShellView *pshv );
>
> @@ -590,6 +596,8 @@ cpp_quote("#endif")
>          [in] LPTBBUTTONSB lpButtons,
>          [in] UINT nButtons,
>          [in] UINT uFlags);
> - [call_as(SetToolbarItems)]
> - HRESULT RemoteSetToolbarItems();

These shouldn't be necessary. What is it that you're trying to fix?
> }
>
> @@ -1441,9 +1449,12 @@ interface IAutoCompleteDropDown : IUnknown
>  {
>  cpp_quote("#define ACDD_VISIBLE   0x0001")
> - HRESULT GetDropDownStatus(
> - [local] HRESULT GetDropDownStatus(
>     [out] DWORD *pdwFlags,
> -
>    [out, string] LPWSTR *ppwszString);
> -
>    [out] LPWSTR *ppwszString);
> -
> - [call_as(GetDropDownStatus)]
> - HRESULT RemoteGetDropDownStatus();

This isn't correct. IAutoCompleteDropDown::GetDropDownStatus should be
remoted as is.
>  HRESULT ResetEnumerator();
>
> }