Re: [PATCH v2] msvcrt: _Gettnames() should respect user overrides.

[Zebediah Figura]

On 01/03/2018 11:32 AM, Piotr Caban wrote:
> Hi Zebediah,
>
> On 01/02/18 21:41, Zebediah Figura wrote:
> > +    for (i = 0; i < sizeof(time_data)/sizeof(time_data[0]); i++)
> > +    {
> > +        size = GetLocaleInfoA(MAKELCID(LANG_ENGLISH, SORT_DEFAULT),
> > +                              time_data[i], buf, sizeof(buf));
> > +        ok(size, "GetLocaleInfo failed: %x\n", GetLastError());
> > +        ok(!strcmp(ret->str[i], buf), "ret->str[%i] = %s, expected
> > %s\n", i, ret->str[i], buf);
> > +    }
> > -
> >
> > free(ret);
> >         if(!setlocale(LC_TIME, "german"))
>
> Is there a reason to not change the German locale test in the same way?
>
> Thanks,
> Piotr

Good point. I've sent an updated patch.