Re: [PATCH v2 1/3] include: Add xact2wb.h

[Alistair Leslie-Hughes]

Hi Vijay,

On 7/11/20 12:42 am, Vijay Kiran Kamuju wrote:
> Signed-off-by: Vijay Kiran Kamuju
>
> +typedef enum WAVEBANKSEGIDX
> +{
> - WAVEBANK_SEGIDX_BANKDATA = 0,
> - WAVEBANK_SEGIDX_ENTRYMETADATA,
> - WAVEBANK_SEGIDX_SEEKTABLES,
> - WAVEBANK_SEGIDX_ENTRYNAMES,
> - WAVEBANK_SEGIDX_ENTRYWAVEDATA,
> - WAVEBANK_SEGIDX_COUNT
>
> +} WAVEBANKSEGIDX, *LPWAVEBANKSEGIDX;

This structure doesn't appear correct, the Dec 2005 SDK header doesn't 
have WAVEBANK_SEGIDX_SEEKTABLES for example.  Please double check.
> +typedef struct WAVEBANKSAMPLEREGION
> +{
> - DWORD dwStartSample;
> - DWORD dwTotalSamples;
>
> +} WAVEBANKSAMPLEREGION, *LPWAVEBANKSAMPLEREGION;

This structure doesn't appear either,  guessing we need to add #if 
around where WAVEBANKENTRY is used, to make it compatible with older 
versions.

Regards
Alistair