Re: [PATCH 1/4] widl: Support WinRT parameterized type parsing.

[Rémi Bernon]

On 2/11/21 4:26 PM, Jacek Caban wrote:
> Hi Rémi,
>
> On 10.02.2021 10:02, Rémi Bernon wrote:
> > And add IVectorView<T> and IIterator<T> parameterized interfaces to
> > windows.foundation.idl for illustration and future use. They won't
> > generate any additional code until they are fully specialized.
> >
> > This is a WIDL-specific feature, but MIDL has some magic knowledge of
> > these Windows.Foundation.Collections interface templates, and we need a
> > way to instruct WIDL about them too.
> >
> > Having these interfaces declared in the IDL, guarded with __WIDL__ ifdef
> > is easier and more flexible than re-creating the types by hand in WIDL
> > source.
>
> The general approach looks good to me, but it looks like splitting 
> patches went wrong:
>
> tools/widl/parser.y:1843:21: warning: ‘append_types’ defined but not 
> used [-Wunused-function]
>
> Thanks,
>
> Jacek

Oops yes, good catch thanks.

This helper was previously in the requires keyword patch. I moved it to 
later patches but missed the right one and missed the warning too. Sorry.

I'll send an update.