Re: [PATCH 3/6] msxml3/tests: Add missing return value checks to domdoc tests (Coverity)

[Nikolay Sivov]

On 01/08/2018 08:05 AM, Alex Henrie wrote:
> Signed-off-by: Alex Henrie
>
> dlls/msxml3/tests/domdoc.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
> index c1b434bc5f..36fa9535b6 100644
> --- a/dlls/msxml3/tests/domdoc.c
> +++ b/dlls/msxml3/tests/domdoc.c
> @@ -6460,7 +6460,8 @@ static void test_save(void)
>       hr = IXMLDOMDocument_loadXML(doc, _bstr_(win1252xml), &b);
>       EXPECT_HR(hr, S_OK);
> - CreateStreamOnHGlobal(NULL, TRUE, &stream);
> - hr = CreateStreamOnHGlobal(NULL, TRUE, &stream);
> - EXPECT_HR(hr, S_OK);
>  V_VT(&dest) = VT_UNKNOWN;
>  V_UNKNOWN(&dest) = (IUnknown*)stream;
>  hr = IXMLDOMDocument_save(doc, dest);
>
> @@ -10950,7 +10951,8 @@ static void test_dispex(void)
>       /* IXMLDOMNodeList */
>       hr = IXMLDOMDocument_getElementsByTagName(doc, _bstr_("*"), &node_list);
>       EXPECT_HR(hr, S_OK);
> - IXMLDOMNodeList_QueryInterface(node_list, &IID_IUnknown, (void**)&unk);
> - hr = IXMLDOMNodeList_QueryInterface(node_list, &IID_IUnknown, (void**)&unk);
> - EXPECT_HR(hr, S_OK);
>  test_domobj_dispex(unk);
>  IUnknown_Release(unk);
>  IXMLDOMNodeList_Release(node_list);
>
> @@ -12094,8 +12096,8 @@ static void test_put_data(void)
>          }

Please unwrap it to a regular ok().
>      /* compare */
> -
>   ok(!lstrcmpW(data, get_data), "%d: got wrong data %s, expected %s\n", *type, wine_dbgstr_w(get_data),
> -
>       wine_dbgstr_w(data));
> -
>   ok(get_data && !lstrcmpW(data, get_data), "%d: got wrong data %s, expected %s\n",
> -
>      *type, wine_dbgstr_w(get_data), wine_dbgstr_w(data));
>    SysFreeString(get_data);
>
>    IXMLDOMNode_Release(node);

Do we have actual crashes because of that?