Re: [PATCH 4/5] d3d9/tests: Fix D3D9Ex tests on Windows 10.

[Henri Verbeet]

On Mon, 25 Feb 2019 at 21:31, Matteo Bruni  wrote:
> dlls/d3d9/tests/d3d9ex.c | 42 +++++++++++++++++++++++-----------------
>  1 file changed, 24 insertions(+), 18 deletions(-)

As a general comment, this patch does several things at once.
> @@ -3518,10 +3519,12 @@ static void test_window_style(void)
>          }
>      style = GetWindowLongA(device_window, GWL_STYLE);
> -
>    todo_wine ok(style == device_style, "Expected device window style %#x, got %#x, i=%u.\n",
> -
>    todo_wine ok((style & ~WS_OVERLAPPEDWINDOW) == (device_style & ~WS_OVERLAPPEDWINDOW),
> -
>            "Expected device window style %#x, got %#x, i=%u.\n",
>            device_style, style, i);
>    style = GetWindowLongA(device_window, GWL_EXSTYLE);
> -
>    todo_wine ok(style == device_exstyle, "Expected device window extended style %#x, got %#x, i=%u.\n",
> -
>    todo_wine ok((style & ~WS_EX_OVERLAPPEDWINDOW) == (device_exstyle & ~WS_EX_OVERLAPPEDWINDOW),
> -
>            "Expected device window extended style %#x, got %#x, i=%u.\n",
>            device_exstyle, style, i);

That seems to defeat the point of the test somewhat. Perhaps that's ok
for d3d9ex though. Which styles does it touch specifically?