On 07.07.2016 23:59, Alex Henrie wrote:
Hi Flan,
Thanks for your interest in contributing to Wine. The Wine project requires you to use your real name (both first and last name) when submitting patches. It might also be a good idea to contact Sebastian Lackner, who is listed as a maintainer of this part of Wine. He might be able to give you more specific feedback, or he might decide to include your patch in Wine Staging to test it with a wider audience.
-Alex
I'm not the maintainer of this component, but Alex is right that you will have to use your real name (both as author and also in the Signed-off-by message).
I also believe that the variable names link_bno1W and link_bno1_str are chosen a bit badly. The 1 does not really make any sense, and instead of "bno" it might be better to use the same abbreviation "basenamed" as above. If you make any changes, please also adjust the whitespace inbetween of the variable name and "=" to match the surrounding code.
If \Sessions\1 contains all the elements from \, you could also think about symlinking it to root (instead of symlinking each component separately).
Regards, Sebastian