Re: [PATCH] server: Add new pipe servers to the end of the servers list.

[Huw Davies]

On Tue, Feb 26, 2019 at 02:56:59PM +0100, Jacek Caban wrote:
> On 2/26/19 12:06 PM, Huw Davies wrote:
> > This ensures instances created first will be connected to first.
> >
> > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41670
> > Signed-off-by: Huw Davies
> >
> > dlls/kernel32/tests/pipe.c | 38 ++++++++++++++++++++++++++++++++++++++
> >   server/named_pipe.c        |  2 +-
> >   2 files changed, 39 insertions(+), 1 deletion(-)
>
> While the patch looks good and has my sign-off, note that it's quite
> incomplete. For example, the order of used servers takes into account order
> of ConnectNamedPipe() calls. I extended your tests to show that it's quite
> incorrect. Also current code will prefer servers created earlier even if
> they just entered listening state while others are waiting longer.
>
> Could you please try the attached follow-up patch and see if the app is fine
> with it?

Hi Jacek,

Thanks for digging further.  Yes, the app is still fine with this
patch.

One thing, in the call to CreateNamedPipeA() in the tests, let's
pass ARRAY_SIZE(server) as the max_instances param - my fault.

Thanks,
Huw.