Re: [PATCH 1/2] riched20/tests: Add tests for IRichEditOleCallback_QueryInsertObject.

[Huw Davies]

On Thu, Mar 31, 2022 at 11:39:05PM +0900, Jinoh Kang wrote:
> Signed-off-by: Jinoh Kang
>
> dlls/riched20/tests/richole.c | 247 ++++++++++++++++++++++++++++++++--
>  1 file changed, 236 insertions(+), 11 deletions(-)
>
> diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c
> index 24284a24484..bb99a9a7276 100644
> --- a/dlls/riched20/tests/richole.c
> +++ b/dlls/riched20/tests/richole.c
> @@ -33,6 +33,169 @@
>  #include <tom.h>
>  #include <wine/test.h>
>
> +#define EXPECT_TODO_WINE 0x80000000UL
> -
>
> +typedef struct IRichEditOleCallbackImpl {

You can drop the typedef.
> - IRichEditOleCallback IRichEditOleCallback_iface;
> - LONG ref;
> - int line;
> -
> - ULONG expect_queryinsertobject;
> -
> - const CLSID *lpclsid;

We generally prefer names like "clsid"
> - LPSTORAGE lpstg;

Similarly, IStorage *stg (and likewise in various function parameters below).
> - LONG cp;
> - HRESULT queryinsertobject_result;
>
> +};