On 2/17/21 1:40 PM, Jacek Caban wrote:
Hi Rémi,
On 16.02.2021 21:15, Rémi Bernon wrote:
+ case STMT_IMPORT: + case STMT_IMPORTLIB: + case STMT_PRAGMA: + case STMT_CPPQUOTE: + fprintf(stderr, "%d\n", stmt->type); + assert(0); + break;
In general, we shouldn't assert or crash on invalid or unsupported syntax. In this particular case, I don't think there is anything special we need to do about those statements, so it seems to me that removing fprintf() and assert() is all we need for those statements. However, I was also able to crash widl by adding a struct declared inside templated interface (which should likely be not supported anyway).
Thanks,
Jacek
Sure, I'll make those error case nicer. I think it's also some remains of development code that I never cleaned, thanks for noticing it.