On Tue, Sep 20, 2011 at 22:17, Martin Wilck mwilck@arcor.de wrote:
Hi Dan,
on my i7 machine, your patch series fails every time for me when run normally. Here's the log:
Did you apply only this one, or also 3/9 which is supposed to fix the test results? Frédéric already told me that I should have submitted the patches in one.
Not exactly. What I said it that you can't fix stuff in patch N and alter .exp in patch N+1, since that would make the test suite run with errors Ideally, what should be done is:
Patch N .cmd add tests
.exp expected results, potentially with some @todo_wine@
Patch N+1 Fix in .c/h files, and removal of @todo_wine@ in .exp
Of course, test suite must run flawlessly after both patch N and N+1 This way you (read AJ) can be sure that there was a bug (patch N) and that patch N+1 fixed it
Only if it's too difficult/not feasible to split into 2 patches (e.g. due to big deficiencies in the test runner, etc.) should you merge them, but that's generally not recommended
Frédéric