Re: [PATCH 2/5] d3dcompiler: Parse return statements without a value.

[Matteo Bruni]

On Mon, Mar 2, 2020 at 5:56 AM Zebediah Figura  wrote:
> diff --git a/dlls/d3dcompiler_43/tests/hlsl_d3d9.c b/dlls/d3dcompiler_43/tests/hlsl_d3d9.c
> index 062ef0a84a9..f1ce5dc5bca 100644
> --- a/dlls/d3dcompiler_43/tests/hlsl_d3d9.c
> +++ b/dlls/d3dcompiler_43/tests/hlsl_d3d9.c
> @@ -730,7 +730,7 @@ static void test_fail(void)
>              compiled = errors = NULL;
>              hr = ppD3DCompile(tests[i], strlen(tests[i]), NULL, NULL, NULL, "test", targets[j], 0, 0, &compiled, &errors);
>              todo_wine ok(hr == E_FAIL, "Test %u, target %s, got unexpected hr %#x.\n", i, targets[j], hr);
> -
>        todo_wine_if (i == 1 || i >= 8) ok(!!errors, "Test %u, target %s, expected non-NULL error blob.\n", i, targets[j]);
> -
>        todo_wine_if (i == 1 || i >= 7) ok(!!errors, "Test %u, target %s, expected non-NULL error blob.\n", i, targets[j]);

Idea for another patch: maybe add a comment here in tests[] every 5
shaders or so to make it easier figuring out which test is which.