Re: [PATCH v2 6/6] d3dcompiler: Return an ID3D10Blob from parse_hlsl().

[Matteo Bruni]

On Thu, Jun 11, 2020 at 10:04 PM Zebediah Figura
 wrote:
> On 6/11/20 2:44 PM, Matteo Bruni wrote:
> > Signed-off-by: Matteo Bruni
> >
> > I think the most important part WRT externally visible behavior is
> > that you're now returning the HRESULT (which is why you can remove the
> > todo_wine). I'd use something like:
> >
> > "d3dcompiler: Return an HRESULT from parse_hlsl()."
> >
> > as commit subject. Not a huge deal though.
>
> True enough, though it's not why I wrote the patch in the first or even
> second place—I wanted to be able to write the blob before freeing some
> data, and then I wanted to be able to write the blob without using the
> bytecodewriter layer.

Yeah, I figured that the HRESULT part was "by chance".